search

TDycores-Project / TDycore

BSD 2-Clause "Simplified" License
4 stars 0 forks source link

Added interface functions for efficiently and clearly accessing mesh entities. #153

Closed jeff-cohere closed 3 years ago

jeff-cohere commented 3 years ago

See #147 for details on this one. We don't have unit tests yet--a candidate mechanism for that is in PR #146.

There are two things remaining for #147:

  1. Self-contained mesh constructor(s) for creating standalone mesh objects.
  2. Unit tests that manipulate these objects
knepley commented 3 years ago

Why do you want to do this?

jeff-cohere commented 3 years ago

Hey Matt,

These interface routines are an alternative to directly accessing the arrays within the mesh data structure, which doesn't read very easily. Do you think this is a bad idea?

knepley commented 3 years ago

I think I understand now. We are already using these structures in the code, and you are just wrapping up the use. That seems reasonable. I would not advocate new code like this, since I would rather we just use the existing API, and fix it if it does not do what we need, but that it too much heavy lifting for this PR,