TDycores-Project / TDycore

BSD 2-Clause "Simplified" License
4 stars 0 forks source link

Fixes Dirichlet boundary condition for TPF #154

Closed bishtgautam closed 3 years ago

bishtgautam commented 3 years ago
bishtgautam commented 3 years ago

@jeff-cohere The code is compiling for me on Ubuntu 20.04 + gcc 9.3.0 and I'm not sure why the code is failing on Github actions. Can you check if the code compiles correctly for you?

bishtgautam commented 3 years ago

I broke few tests and am working on fixing them.

jeff-cohere commented 3 years ago

Hey @bishtgautam ,

Try building with make V=1 codecov=1 like the GitHub action does. The library builds, but if you build the demo directory, you'll probably see the internal compiler error we've been encountering:

make V=1 codecov=1 -j       # should be okay
cd demo
make V=1 codecov=1 -j
...
/home/jeff/projects/pnnl/TDycore/demo/transient/transient_snes_mpfaof90.F90:108:0:

  108 |   use tdycore
      |
internal compiler error: in coverage_begin_function, at coverage.c:656
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-10/README.Bugs> for instructions.
make[1]: *** [/home/jeff/projects/pnnl/petsc/lib/petsc/conf/rules:286: transient_snes_mpfaof90.o] Error 1
make[1]: *** Waiting for unfinished jobs....
bishtgautam commented 3 years ago

@jeff-cohere Thanks for info. I will debug this error.

jeff-cohere commented 3 years ago

I'm not sure it can be debugged--I suspect it's the same thing we're hitting with #152.

If we wanted to get past this before GCC 11 is widely available, we could disable code coverage on Fortran executables.

bishtgautam commented 3 years ago

@jeff-cohere I have disabled the build of F90 with codecov=1.

jeff-cohere commented 3 years ago

Great! Anything you'd like me to look at in particular for this PR?