Closed bishtgautam closed 3 years ago
Looks like there's a failure with the wedge test. The code changes look fine. I prefer the type safety of static const
to #define
, so if no one is opposed to that, maybe we can switch the constants over to that style of declaration.
Merging #168 (a7e070c) into master (a9ac7a2) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #168 +/- ##
=======================================
Coverage 67.73% 67.73%
=======================================
Files 7 7
Lines 1221 1221
=======================================
Hits 827 827
Misses 394 394
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a9ac7a2...a7e070c. Read the comment docs.
This PR is good to go from my end.