search

TDycores-Project / TDycore

BSD 2-Clause "Simplified" License
4 stars 0 forks source link

Update some function prototypes and definitions to be consistent about using PetscReal vs. double. #170

Closed rtmills closed 3 years ago

rtmills commented 3 years ago

This PR fixes some consistency issues with using PetscReal vs. double that showed up when I tried building TDycores using single precision (for testing on Intel integrated GPUs that do not support double precision).

bishtgautam commented 3 years ago

@rtmills When trying to resolve conflicts, I noticed that many demos were still using double. I found it easier to do a find-replace in all files than to resolve conflicts. If you are okay with it, we can close this PR and you can review #171.

rtmills commented 3 years ago

@bishtgautam, your fix in #171 is definitely better. Let's close this one. (I've already reviewed and approved #171). Thanks!