Renamed boundary-condition-related functions to better describe their purposes

TDycores-Project / TDycore

BSD 2-Clause "Simplified" License

4 stars 0 forks source link

Renamed boundary-condition-related functions to better describe their purposes #185

Closed jeff-cohere closed 3 years ago

jeff-cohere commented 3 years ago

TDySetDirichletValueFunction -> TDySetBoundaryPressureFn
TDySetTemperatureDirichletValueFunction -> TDySetBoundaryTemperatureFn
TDySetDirichletFluxFunction -> TDySetBoundaryVelocityFn

Boundary conditions are tricky enough! It's important for us to be precise about our language. C and Fortran interfaces have been updated, and all the demos use the new functions.

FYI @ghammond86 @nocollier

nocollier commented 3 years ago

I think this is a good idea and the naming switches seem ok to me. In addition it clears up some ambiguity. In the weak form of the mixed FE formulation the Dirichlet conditions set are velocity conditions and the Neumann are pressures, the reverse of what is typical. That is, a boundary integral term emerges from integration by parts with pressure leading to a natural means to enforce conditions, but the velocity conditions must be built into the space.