Closed jeff-cohere closed 2 years ago
SPE10/steady.c
mpfao/mpfao.c
richards/richards_driver.c
qa_test/qa_test.c
richards/richards_driver.c
steady/steady.c
steadyblock/steadyblock.c
steadyf90/steadyf90.F90
steady/steady.c
th/th_driver.c
transient/transient.c
transient/transient_mpfao.c
richards/richards_driver.c
transient/transient_mpfaof90.F90
transient/transient_snes_mpfaof90.F90
transient/transient_th_mpfao.c
th/th_driver.
Thanks, Gautam!
This is a helpful directory of what we have. The SPE10 problem is really just setting up a flow via a imposed pressure gradient diagonal to the mesh using the permeability fields from that problem. We used it as a stress test for solvers--it doesn't really solve anything real. On the one hand, it does not really need a test and we could remove. On the other, why relocate it to another place making it harder to find when we need it again? I would leave it, but don't feel strongly about it.
I think it's fine to keep "historical" things around, as long as we document their purpose. A stress test for solvers sounds like a nice tool/benchmark to keep around.
I'm going to remove the 2D MPFA-O code in a pull request, and then I'll turn my attention to the demos in general.
Seems like we can close this issue now. Any objections, @bishtgautam ?
The is still a bunch of 2D MPFA-O code that can be deleted. e.g. https://github.com/TDycores-Project/TDycore/blob/master/src/mpfao/tdycoremesh.c#L1362. If no one else is working on it, I can work next week on removing the remaining MPFA-O 2D code.
In the interest of focusing on what we need to be relevant to a project like E3SM, I think it would be good for us to start a conversation about what we can get rid of, now that we know a bit more what we're doing.
Here are some starter questions (at varying levels of provocation):
@bishtgautam , if it's appropriate, maybe we can talk about this at our next joint meeting.