TDycores-Project / TDycore

BSD 2-Clause "Simplified" License
4 stars 0 forks source link

Save cell geometric attributes #202

Closed bishtgautam closed 2 years ago

bishtgautam commented 3 years ago
jeff-cohere commented 3 years ago

Are we providing these options to bypass the geometry calculation because it's so expensive? I can see doing this for testing purposes while we're optimizing these kinds of calculations, but I'd rather spend energy trying to make geometry cheaper to calculate than providing options which allow users to get themselves into trouble (think about using older geometry files with meshes that have been recently modified).

bishtgautam commented 3 years ago

Are we providing these options to bypass the geometry calculation because it's so expensive?

Yes and this might be a temporary fix to reduce initialization cost.

knepley commented 3 years ago

On Mon, Aug 16, 2021 at 2:31 PM Gautam Bisht @.***> wrote:

Are we providing these options to bypass the geometry calculation because it's so expensive?

Yes.

Just computing geometry once is expensive? It should be about the same cost as a residual evaluation. Is it more?

Thanks,

 Matt

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/TDycores-Project/TDycore/pull/202#issuecomment-899764486, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEORCNS3F4SQM42YKMCYSLT5FRQDANCNFSM5CII47YA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. -- Norbert Wiener

https://www.cse.buffalo.edu/~knepley/ http://www.cse.buffalo.edu/~knepley/

bishtgautam commented 3 years ago

My goal here is to reduce the initialization time for the purpose of quickly debugging the code.

bishtgautam commented 2 years ago

@jeff-cohere This is now ready for your review.