Closed jeff-cohere closed 3 years ago
Merging #204 (3cb319b) into master (974f999) will decrease coverage by
8.08%
. The diff coverage isn/a
.:exclamation: Current head 3cb319b differs from pull request most recent head 35c875b. Consider uploading reports for the commit 35c875b to get more accurate results
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
- Coverage 67.81% 59.72% -8.09%
==========================================
Files 7 7
Lines 1224 1224
==========================================
- Hits 830 731 -99
- Misses 394 493 +99
Impacted Files | Coverage Δ | |
---|---|---|
demo/mpfao/mpfao.c | 39.79% <0.00%> (-50.52%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 974f999...35c875b. Read the comment docs.
Looks like we're losing some code coverage here. I guess that's not too surprising, considering the tests we've jettisoned. @bishtgautam , let me know if you're concerned about this in the short term. Further pruning might improve coverage.
I'm not worried about the decrease in code coverage. At some point, we will have to add tests to improve code coverage.
This PR gets rid of all 2D logic in the MPFA-O code and merges the
src/mpfao/3D
source directory intosrc/mpfao
. Related functions with3D
in their names are renamed to simpler names. All 2D MPFA-O tests have been removed. This is the first step of the pruning process outlined in #200.Closes #46