TDycores-Project / TDycore

BSD 2-Clause "Simplified" License

4 stars 0 forks source link

[WIP] Save information about mesh partition for debugging #209

Closed bishtgautam closed 2 years ago

bishtgautam commented 2 years ago

Each rank independently outputs binary vectors for control volumes and vertices.

The vector for cells has the following information:
1. Natural ID
2. Is the cell a local cell (=1) or ghost cell (=0)
3. Number of vertices forming the cell
4. IDs of vertices (in local order)
The vector for vertices has the following information
1. x,y,z coordinate
2. Is vertex a local vertex (=1) or ghost vertex (=0)
3. Number of cells that share the vertex
4. IDs of cells (in local order)

codecov-commenter commented 2 years ago

Codecov Report

Merging #209 (6b2b574) into master (adc0c5e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   49.19%   49.19%           
=======================================
  Files           4        4           
  Lines         683      683           
=======================================
  Hits          336      336           
  Misses        347      347

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update adc0c5e...6b2b574. Read the comment docs.

jeff-cohere commented 2 years ago

Hey @bishtgautam . Do you think we should stick the related command-line option into one of our tests to get test coverage on this new feature?

jeff-cohere commented 2 years ago

Hey @bishtgautam . Is this ready for (re-)review? I see a lot of time-integrator-related changes in addition to the debugging information you describe above. Are those from another branch that got merged, or just stuff you're including in this PR?

bishtgautam commented 2 years ago

@jeff-cohere It is still a WIP and I updated the title to reflect it. Thanks for checking in about this PR.

bishtgautam commented 2 years ago

Based on our discussion during today's call, I'm closing this PR. These mesh diagnostics functions will be re-implemented and outputted in HDF5 format.