Closed bishtgautam closed 2 years ago
Thanks, @bishtgautam . Probably a lot of these issues were oversights on my part when I was refactoring.
One question: I see you've added an ncells
parameter to TDyUpdateState
and its related functions. Because the first argument is a DM, it's possible to get the number of cells without this extra argument. And if ncells
disagrees with the DM about the number of cells, we will get unexpected behavior. So I would recommend not having this extra parameter, unless I'm missing something.
I created #224. Let me do a review of this PR so we can get it merged.
Merging #221 (516e6a2) into master (d2a915c) will not change coverage. The diff coverage is
100.00%
.:exclamation: Current head 516e6a2 differs from pull request most recent head dc57dd2. Consider uploading reports for the commit dc57dd2 to get more accurate results
@@ Coverage Diff @@
## master #221 +/- ##
=======================================
Coverage 51.63% 51.63%
=======================================
Files 4 4
Lines 765 765
=======================================
Hits 395 395
Misses 370 370
Impacted Files | Coverage Δ | |
---|---|---|
demo/richards/richards_driver.c | 100.00% <100.00%> (ø) |
|
demo/th/th_driver.c | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d2a915c...dc57dd2. Read the comment docs.
To remove the NR code, I squashed all commits into a single commit.
This PR contains multiple bug fixes for parallel runs.