Fixed a leak by destroying TS/SNES solvers with time integrator

TDycores-Project / TDycore

BSD 2-Clause "Simplified" License

4 stars 0 forks source link

Fixed a leak by destroying TS/SNES solvers with time integrator #227

Closed jeff-cohere closed 2 years ago

jeff-cohere commented 2 years ago

Turns out we haven't been destroying our solvers properly when we destroy the time integrator. These solvers were keeping a reference to the primary DM and preventing it from being cleaned up. With this PR, we get a clean bill of health from Valgrind (at least for the TH test case mentioned in #223).

Fixes #223

jeff-cohere commented 2 years ago

Interesting--now we have some test failures! I'll see if I can round them up.