Closed bishtgautam closed 2 years ago
Merging #230 (c2116a7) into master (f23ef7e) will decrease coverage by
0.06%
. The diff coverage is50.00%
.
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
- Coverage 51.63% 51.57% -0.07%
==========================================
Files 4 4
Lines 765 764 -1
==========================================
- Hits 395 394 -1
Misses 370 370
Impacted Files | Coverage Δ | |
---|---|---|
demo/transient/transient.c | 0.00% <0.00%> (ø) |
|
demo/steady/steady.c | 54.13% <50.00%> (ø) |
|
demo/richards/richards_driver.c | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f23ef7e...c2116a7. Read the comment docs.
@jeff-cohere This is ready for your review. The only outstanding issue is the inconsistent use of memory allocation/deallocation (malloc
vs PetscMalloc
). This is already a huge PR. So, how about you create a new PR that makes memory allocation/deallocation consistent?
I rebased this branch against master
to fix a merge conflict. @bishtgautam , I agree that the memory inconsistencies can be sorted in a separate smaller PR. Let's make sure the tests pass and then I can merge (unless @jedbrown wants to weigh in).
Adds PFLOTRAN's approach for managing a DM, which is an alternative to PETSc-managed DMPlex. This approach allows for a more direct comparison of TDycore and PFLOTRAN approaches.