TDycores-Project / TDycore

BSD 2-Clause "Simplified" License
4 stars 0 forks source link

Update PetscOptionsBegin/End for petsc-3.18/main #243

Closed jedbrown closed 1 year ago

jedbrown commented 1 year ago

We could consider adopting PetscCall notation and clang-format if others like it, but this gets things compiling (and fixes a couple format strings).

codecov-commenter commented 1 year ago

Codecov Report

Base: 51.04% // Head: 51.05% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (0972d4b) compared to base (36194b9). Patch coverage: 72.97% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #243 +/- ## ======================================= Coverage 51.04% 51.05% ======================================= Files 48 48 Lines 14207 14201 -6 ======================================= - Hits 7252 7250 -2 + Misses 6955 6951 -4 ``` | [Impacted Files](https://codecov.io/gh/TDycores-Project/TDycore/pull/243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project) | Coverage Δ | | |---|---|---| | [demo/richards/richards\_driver.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-ZGVtby9yaWNoYXJkcy9yaWNoYXJkc19kcml2ZXIuYw==) | `0.00% <0.00%> (ø)` | | | [demo/th/th\_driver.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-ZGVtby90aC90aF9kcml2ZXIuYw==) | `0.00% <0.00%> (ø)` | | | [demo/transient/transient.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-ZGVtby90cmFuc2llbnQvdHJhbnNpZW50LmM=) | `0.00% <0.00%> (ø)` | | | [src/fv/fvtpf/tdyfvtpf.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-c3JjL2Z2L2Z2dHBmL3RkeWZ2dHBmLmM=) | `0.00% <0.00%> (ø)` | | | [src/materials/tdycharacteristiccurves.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-c3JjL21hdGVyaWFscy90ZHljaGFyYWN0ZXJpc3RpY2N1cnZlcy5j) | `85.91% <0.00%> (+0.29%)` | :arrow_up: | | [src/tdyio.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-c3JjL3RkeWlvLmM=) | `15.42% <66.66%> (-0.24%)` | :arrow_down: | | [demo/steady/steady.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-ZGVtby9zdGVhZHkvc3RlYWR5LmM=) | `54.13% <100.00%> (ø)` | | | [src/fe/tdybdm.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-c3JjL2ZlL3RkeWJkbS5j) | `91.62% <100.00%> (ø)` | | | [src/fe/tdywy.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-c3JjL2ZlL3RkeXd5LmM=) | `70.46% <100.00%> (ø)` | | | [src/fv/mpfao/tdympfao.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-c3JjL2Z2L21wZmFvL3RkeW1wZmFvLmM=) | `71.38% <100.00%> (ø)` | | | ... and [3 more](https://codecov.io/gh/TDycores-Project/TDycore/pull/243/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jeff-cohere commented 1 year ago

Also, I'm all for clang-format (though I have noticed that its output doesn't always seem stable between versions).

jedbrown commented 1 year ago

I think this will all compile with older PETSc too.

Yeah, clang-format changes a little between versions, but it's nice to remove the cognitive load of anything to do with formatting.