TDycores-Project / TDycore

BSD 2-Clause "Simplified" License
4 stars 0 forks source link

Eliminated error norm calculation functions. #245

Closed jeff-cohere closed 1 year ago

jeff-cohere commented 1 year ago

These functions aren't being used, and complicate some of our current refactoring/design work. We can reintroduce error calculations when it's logical to do so.

codecov-commenter commented 1 year ago

Codecov Report

Base: 51.05% // Head: 50.28% // Decreases project coverage by -0.76% :warning:

Coverage data is based on head (cb9ab43) compared to base (4d973e0). Patch has no changes to coverable lines.

:exclamation: Current head cb9ab43 differs from pull request most recent head ef44f7a. Consider uploading reports for the commit ef44f7a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #245 +/- ## ========================================== - Coverage 51.05% 50.28% -0.77% ========================================== Files 48 48 Lines 14201 13932 -269 ========================================== - Hits 7250 7006 -244 + Misses 6951 6926 -25 ``` | [Impacted Files](https://codecov.io/gh/TDycores-Project/TDycore/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project) | Coverage Δ | | |---|---|---| | [demo/steady/steady.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-ZGVtby9zdGVhZHkvc3RlYWR5LmM=) | `41.69% <ø> (-12.45%)` | :arrow_down: | | [src/f90-mod/tdycoref.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-c3JjL2Y5MC1tb2QvdGR5Y29yZWYuYw==) | `57.50% <ø> (+1.40%)` | :arrow_up: | | [src/fe/tdybdm.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-c3JjL2ZlL3RkeWJkbS5j) | `91.19% <ø> (-0.44%)` | :arrow_down: | | [src/fe/tdywy.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-c3JjL2ZlL3RkeXd5LmM=) | `67.07% <ø> (-3.40%)` | :arrow_down: | | [src/fv/fvtpf/tdyfvtpf.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-c3JjL2Z2L2Z2dHBmL3RkeWZ2dHBmLmM=) | `0.00% <ø> (ø)` | | | [src/fv/mpfao/tdympfao.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-c3JjL2Z2L21wZmFvL3RkeW1wZmFvLmM=) | `73.50% <ø> (+2.12%)` | :arrow_up: | | [src/tdycore.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-c3JjL3RkeWNvcmUuYw==) | `59.85% <ø> (-0.25%)` | :arrow_down: | | [src/tdyconditions.c](https://codecov.io/gh/TDycores-Project/TDycore/pull/245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project#diff-c3JjL3RkeWNvbmRpdGlvbnMuYw==) | `46.52% <0.00%> (-2.78%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TDycores-Project)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.