TEA-ebook / teabook-open-reader

TeaBook Open Reader - EPUB web reader, with offline access
Other
127 stars 32 forks source link

Broken demo: Mod: update sticky.js to 2.9 #31

Closed eunomie closed 11 years ago

eunomie commented 11 years ago

The demo (http://demo-open-reader.tea-ebook.com/) is broken with chrome 25+.

This is just a little patch to upgrade version of sticky.js to 2.9. See https://github.com/TEA-ebook/teabook-open-reader/issues/29 for some details.

I have not tested but the difference between 2.8 and 2.9 is mainly the patch by @noplay and the other part is just an other way to access indexedDB outside global namespace.

julien-duponchelle commented 11 years ago

Anynews about that?

imjufu commented 11 years ago

Hi guys, sorry for the late reply. Thanks for this PR @CrEv! After testing your PR, i see that you forgot 2 files and the reader is broken. Oopsie. https://github.com/TEA-ebook/teabook-open-reader/blob/master/app/assets/javascripts/reader/lib.js#L32 https://github.com/TEA-ebook/teabook-open-reader/blob/master/app/assets/javascripts/reader_sandbox/lib.js#L36 Could you fix it ? I merge your PR asap!

eunomie commented 11 years ago

@Koin: :ballot_box_with_check:

imjufu commented 11 years ago

:+1: