search

TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education
https://teammatesv4.appspot.com/
GNU General Public License v2.0
1.67k stars 3.3k forks source link

cookie is added to response without the 'secure' flag being set. #10019

Closed amarlearning closed 4 years ago

amarlearning commented 4 years ago

cookies are added to response without the 'secure' flag being set.

https://github.com/TEAMMATES/teammates/blob/e01257fdd6870d5b9c569c26e55e33f6ad6a1875/src/main/java/teammates/ui/webapi/action/JsonResult.java#L52-L64

tkech17 commented 4 years ago

i'll do it

tkech17 commented 4 years ago

As i can write only one task assigned as FirstTimers, please assign it two me

madanalogy commented 4 years ago

As i can write only one task assigned as FirstTimers, please assign it two me

You can proceed to submit a PR to address this issue. If anyone else would like to work on it they will check in with you first (if you have yet to submit a PR) so don't worry.

Also, take note of https://github.com/TEAMMATES/teammates/issues/10021#issuecomment-613499993. All the best! Let us know if you need any help :)

madanalogy commented 4 years ago

It appears that adding the secure flag impacts the e2e testing being performed as seen in #10024, therefore upgrading this to a contributor level difficulty

amarlearning commented 4 years ago

I would like to take this one if no one is taking

ghost commented 4 years ago

can anyone explain how it is effecting e2e testing or can provide more details on that? I am firstTimer here.

madanalogy commented 4 years ago

can anyone explain how it is effecting e2e testing or can provide more details on that? I am firstTimer here.

@amarlearning has already indicated that he will be working on this issue. Managing the e2e testing is more complicated than advisable for first timers. Maybe you can consider working on a first timer issue instead? We have a first timer epic you could take a shot at contributing to in #10042