search

TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education
https://teammatesv4.appspot.com/
GNU General Public License v2.0
1.67k stars 3.3k forks source link

Instructor creating courses: auto-trim text fields #11941

Closed damithc closed 2 years ago

damithc commented 2 years ago

v8.19.2, production

Current: When creating a course, there will be an error message if the course ID or the name has leading/trailing white spaces

image

Suggestion: Auto-trim those fields as such leading/trailing spaces are sure to be accidental rather than intended.

domlimm commented 2 years ago

Hello prof, I would like to please pick up this issue.

damithc commented 2 years ago

@domlimm let's leave this to a first time contributor (unless someone from the dev team thinks it is too much for a first timer)

thomasengels commented 2 years ago

I would like to take this on :D my first contribution to opensource

Basfar commented 2 years ago

I would like to take this up

Ranzeb commented 2 years ago

HI, I would like to take this issue up and try to fix it

fsgmhoward commented 2 years ago

Lets make it first come first serve. @thomasengels Would you like to proceed with it?

thomasengels commented 2 years ago

Definitely :D

Shubhcs01 commented 2 years ago

Is this issue resolved?

thomasengels commented 2 years ago

I will check the code later today. Just have been super busy with my actual developer job

akhil9281 commented 2 years ago

Hello, I would like to work this issue. Can anyone tell me which file does this "COURSES" exist ??

seb-lex commented 2 years ago

Hello, I would like to work this issue. Can anyone tell me which file does this "COURSES" exist ??

I couldn't find it either. I did a text search for words on the page but found numerous files containing it. Not sure what we'd edit.

fsgmhoward commented 2 years ago

@thomasengels Any updates?

@akhil9281 @seb-lex Hold on first. Someone has taken it and yet to give up. It would probably not be nice to post duplicated PR on the same issue. If you would still like to investigate the issue, for the handler, I would suggest to trace down by finding the correct servlet class from this file: https://github.com/TEAMMATES/teammates/blob/675374990ed027b474f63fc40ccfd7524ff0baaf/src/main/webapp/WEB-INF/web.xml

LokeshSingh1102 commented 2 years ago

Hey is the issue still open? . I would like to take this on . my first contribution to opensource

fsgmhoward commented 2 years ago

I think it can be considered that @thomasengels gave up on this since no replies has been received.

@Basfar @Ranzeb @Shubhcs01 @akhil9281 @seb-lex Any of you would like to take a look at this? If not, will pass to @LokeshSingh1102 .

ethanotran commented 2 years ago

Is this issue open? looking for my first contribution to open source projects.

LokeshSingh1102 commented 2 years ago

I think they are not taking this on. Should i proceed with this issue @fsgmhoward??

thomasengels commented 2 years ago

Someone else can take it

ethanotran commented 2 years ago

I tried to build the back-end server, in Git Bash using both ./gradlew serverRun & and ./gradlew.bat serverRun &. The results are the same: I never got to "BUILD SUCCESSFUL". Instead, the console outputs:
<===========--> 85% EXECUTING [45m 48s] The time in the brackets keep incrementing, even if I leave the console overnight. The time gets updated but it never gets past 85%. Can you give me some pointers to move forward?

domlimm commented 2 years ago

@ethanotran hello, this is the intended behavior. Could refer to #11889.

ethanotran commented 2 years ago

I'm trying to fix this issue. I would like to first replicate the issue, I believe I need instructor privilege in order to create a course. Since I'm not an instructor, what can I do to gain sufficient privilege for issue replication?

fsgmhoward commented 2 years ago

@LokeshSingh1102 Sure. Please go ahead.

ShubhraSuman commented 2 years ago

Can you assign it to me?

tusharrajpoot commented 2 years ago

@fsgmhoward can i work with this issue?

KillerEnigma commented 2 years ago

I would like to work on this issue @fsgmhoward

ypinhsuan commented 2 years ago

Hi @ShubhraSuman there is no open PR for this issue, would you like to work on it?

ShubhraSuman commented 2 years ago

Sure @ypinhsuan

glowing-sea commented 2 years ago

@damithc @fsgmhoward may I work on this issue? I can do it immediately.

My idea of doing it is to let sanitizeForSaving() in src/main/java/teammates/common/datatransfer/attributes/CourseAttributes.java to trim the course name. This can be done by adding only one line of code. Also, trimming invalid names into valid should be the job of sanitizeForSaving() and this approach is aligned with the origianl structure of the code.

I are doing a group assignment at uni that has to work on an issue from open-source software. We hope to contribute as much as possible as the due date is very soon. I will greatly appreciate it if you allow me to work on this issue.

glowing-sea commented 2 years ago

@fsgmhoward @ypinhsuan Sorry accidentally open a PR. I think I should contact you and get your approval before working on this issue. If you allow me to do this issue, I will open a pull request again.

fsgmhoward commented 2 years ago

Hi @Haoting-Chen , the person taking this issue previously has not given up. Please seek other issues to work on. Thank you so much.

glowing-sea commented 2 years ago

@ShubhraSuman Sorry for bothering you. I am currently working on a group assignment at uni that we have to solve as many issues as we can for Teammates. The assignment is due next week. If you haven't started yet, would you like to hand over this issue to me? I have figured out how to do it and can start immediately.

ShubhraSuman commented 2 years ago

okay u can take it.

glowing-sea commented 2 years ago

@ShubhraSuman Thank you so much for giving me the issue. @fsgmhoward @damithc Could you please assign the issue to me?

glowing-sea commented 2 years ago

Hi, I have completed this issue and submitted a PR https://github.com/TEAMMATES/teammates/pull/11974