search

TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education
https://teammatesv4.appspot.com/
GNU General Public License v2.0
1.67k stars 3.3k forks source link

instructorEvalResultDownload: commas in the student name mess up the downloaded csv file #1247

Closed damithc closed 10 years ago

damithc commented 10 years ago

From dam...@gmail.com on October 18, 2013 19:12:24

as per title

Original issue: http://code.google.com/p/teammatespes/issues/detail?id=1248

damithc commented 10 years ago

From Gigi...@gmail.com on March 04, 2014 17:22:38

Sir, can I take this one?

damithc commented 10 years ago

From dam...@gmail.com on March 04, 2014 19:59:19

Go ahead and submit a patch Kai. We allow GSoC applicants to submit patches for open issues after they have done one issue. No need to get it assigned to you.

damithc commented 10 years ago

From Gigi...@gmail.com on March 07, 2014 14:47:54

Code review: https://codereview.appspot.com/72640046/ Preview: http://xiekai.im/commaCsv.png Based on the CSV standard http://tools.ietf.org/html/rfc4180 , We can fix this issue by using double quotation to include the value. Eg: Paul, Mike ==> "Paul, Mike", then the comma inside will no longer be considered as a separator

damithc commented 10 years ago

From dam...@gmail.com on March 07, 2014 19:06:27

Owner: Gigi...@gmail.com
Labels: Reviewer-Arnold

damithc commented 10 years ago

From Gigi...@gmail.com on March 07, 2014 20:27:19

Status: ReadyForReview

damithc commented 10 years ago

From arnold.k...@gmail.com on March 09, 2014 20:33:48

added comments at review site.

By the way, maybe feedback session results can benefit from the same changes?

Status: ChangesRequested

damithc commented 10 years ago

From Gigi...@gmail.com on March 09, 2014 21:42:33

noted

Status: Started

damithc commented 10 years ago

From Gigi...@gmail.com on March 09, 2014 21:45:35

@arnold.koroa

feedback session results' csv should be fine, as it's sanitized already

damithc commented 10 years ago

From Gigi...@gmail.com on March 09, 2014 22:12:48

Code review: https://codereview.appspot.com/72640046/

Status: ReadyForReview

damithc commented 10 years ago

From arnold.k...@gmail.com on March 10, 2014 19:51:55

This issue was updated by revision 02fd08ad655d .

Status: Delivered

damithc commented 10 years ago

From dam...@gmail.com on March 14, 2014 23:34:42

Status: Deployed
Labels: Milestone-V4.91

damithc commented 10 years ago

[Change Log] status: null ~> status.closed