TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education
https://teammatesv4.appspot.com/
GNU General Public License v2.0
1.67k stars 3.3k forks source link

Improve test code coverage of core components #12588

Open cedricongjh opened 1 year ago

cedricongjh commented 1 year ago

Description of feature/enhancement The components in src/web/app/components are used throughout TEAMMATES, but some of them have poor test coverage. Let's improve the test coverage in these components:

Steps to contribute

  1. Choose component(s) to work on in the table below, and comment on this issue to indicate that you'd like to contribute tests for the component(s)
  2. Create a PR with tests for the component, check the codecov link to ensure that the functionality not covered are indeed tested
  3. Submit the PR, link it to this issue by starting the description with "Part of #12588"
Components: Component Assignee Codecov PR Done
AddingQuestionPanelComponent - link -
CommentEditFormComponent @HarryLu33 link https://github.com/TEAMMATES/teammates/pull/12604
CommentRowComponent @ThomasGreen123 link https://github.com/TEAMMATES/teammates/pull/12612
CommentTableComponent - link -
CommentTableModalComponent @kenneySiu link https://github.com/TEAMMATES/teammates/pull/12609
CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe @cedricongjh link1, link2, link3, link4 https://github.com/TEAMMATES/teammates/pull/12589
CopyCourseModalComponent @cedricongjh link https://github.com/TEAMMATES/teammates/pull/12590
CopySessionModalComponent @Astrid641 link https://github.com/TEAMMATES/teammates/pull/12616
CourseEditFormComponent @lunoos link https://github.com/TEAMMATES/teammates/pull/12597
DatepickerComponent @dlimyy link https://github.com/TEAMMATES/teammates/pull/12592
DatePickerFormatter @dlimyy link https://github.com/TEAMMATES/teammates/pull/12593
ErrorReportComponent @u7488099 link https://github.com/TEAMMATES/teammates/pull/12610
ExtensionConfirmModalComponent @MatheuMa link https://github.com/TEAMMATES/teammates/pull/12622
FeedbackPathPanelComponent @JYH11 link https://github.com/TEAMMATES/teammates/pull/12613
LogsHistogramComponent - link -
LogsTableComponent - link -
LogsDetails - link -
LogsLine - link -
QuestionEditForm @abaduy123 link -
QuestionResponsePanelComponent @leyguan link https://github.com/TEAMMATES/teammates/pull/12867
GqrRqgViewResponsesComponent @RohithSurya link -
GroupedResponsesComponent - link -
GrqRgqViewResponsesComponent - link -
PerQuestionViewResponsesComponent @WayyGood link -
SingleStatisticsComponent @hberehan link -
InstructorResponsesViewBase @justinsegawa link -
QuestionSubmissionFormComponent @kaioenzo link -
RecipientTypeNamePipe @ThomasGreen123 link https://github.com/TEAMMATES/teammates/pull/12626
QuestionConstraint @cedricongjh link https://github.com/TEAMMATES/teammates/pull/12747
QuestionEditAnswerForm @skylar-mo link -
QuestionEditDetailsForm @rushithapenikalapati link -
RichTextEditorComponent - link -
SessionEditForm @kenneySiu link https://github.com/TEAMMATES/teammates/pull/12627
SessionsTable - link -
StudentList @cedricongjh link #12854
ToastComponent @techMedMau link https://github.com/TEAMMATES/teammates/pull/12916
ViewResultsPanelComponent @techMedMau link https://github.com/TEAMMATES/teammates/pull/12918
VisibilityMessages - link -
VisiblityPanel @Andy-W-Developer link https://github.com/TEAMMATES/teammates/pull/12868
techMedMau commented 8 months ago

Hi, may I work on ToastComponent?

weiquu commented 8 months ago

Sure @techMedMau, have edited the comment to assign the component to you

techMedMau commented 8 months ago

Hi, may I also work on ViewResultsPanelComponent? I notice that the good first issue label is added, but I already tried working on it locally.

cedricongjh commented 8 months ago

hey @techMedMau, feel free to submit a pr for it

rushithapenikalapati commented 8 months ago

Hi, can I work on QuestionEditDetailsForm?

skylar-mo commented 8 months ago

Hi, may I work on the QuestionEditAnswerForm?

WayyGood commented 8 months ago

Hi! Can I work on PerQuestionViewResponsesComponent? thanks!

cedricongjh commented 8 months ago

hi @rushithapenikalapati, @skylar-mo and @WayyGood, do go ahead and submit a PR!

kaioenzo commented 7 months ago

Hi! Can I Work on QuestionSubmissionFormComponent?

RohithSurya commented 7 months ago

Hey Guys.. I would like to write tests for GqrRqgViewResponsesComponent and working on it

ziqing26 commented 7 months ago

@kaioenzo @RohithSurya Hi feel free to submit a PR!

WayyGood commented 7 months ago

Hi! Got started on the coverage. Is there any special permission i need in order to submit a PR?

rushithapenikalapati commented 7 months ago

hi @rushithapenikalapati, @skylar-mo and @WayyGood, do go ahead and submit a PR!

When I push my changes upstream I'm getting an error that says "authentication failed"

justinsegawa commented 7 months ago

Hello, can I work on InstructorResponsesViewBase component for a class assignment?

cedricongjh commented 7 months ago

hi @justinsegawa, go ahead!

hberehan commented 7 months ago

Hello, may I start working on the SingleStatisticsComponent for a class assignment due the April 26th?

cedricongjh commented 7 months ago

hi @hberehan, go ahead

itstrueitstrueitsrealitsreal commented 5 months ago

Hi, @cedricongjh, can I work on the tests for AddingQuestionPanelComponent?

Selena-WZ commented 1 month ago

Hi, may I work on the VisibilityMessages?

Adeeth101 commented 1 month ago

@cedricongjh I am a student at the Australian National University working with a 4 person team. We are interested in working on open source projects like this one. We are all new to this repository and would love to contribute to this issue. I see that there are certain test cases that need coverage.

Can we be assigned to: AddingQuestionPanelComponent CommentTableComponent

Let me know if these are available. If not please advise on which tests still need coverage. Thank you.

SamGreenwood04 commented 1 month ago

Hi @cedricongjh, I am keen on working on the "LogsTableComponent" component. If it is still available, may I please be assigned to it? Thanks!

rafgiann commented 3 weeks ago

hello @cedricongjh can i work on the tests for LogsLine? thanks!

vilioupa commented 3 weeks ago

Hi @cedricongjh , can i work on the tests for the LogsHistogramComponent? Thanks!

tourkaelisa commented 3 weeks ago

Hi @cedricongjh i am intrested in working on "GroupedResponsesComponent" , can I? Thanks!!

sofiaapap commented 3 weeks ago

Hello @cedricongjh I would like to contribute on "RichTextEditorComponent" if that's possible. Thank you!