Copying feedback session: Name for copied session should not be whitespace

domlimm commented 10 months ago

Steps to reproduce

Head to Sessions page.
On any course, click on Copy.
You should see this that the Name for copied session* has the same name as the Session you clicked Copy on. Now, clear the text input and this is what you will get below.

Now, let's try to add a whitespace. Validation passes i.e., There is a value for the copied session's name and it is a whitespace.

Expected behaviour

Whitespace should not be allowed for the copied session's name. Input validation should not allow whitespaces.

Actual behaviour

Converse of the above expected behaviour, i.e., Currently, whitespace as name is allowed and this happens after clicking on Copy:

This is validated on the client side. However, we should validate on the form first.

Additional info

Motivation for this issue from a PR: https://github.com/TEAMMATES/teammates/pull/12670#issuecomment-1868207324

Proposed Solution:

You may look at this link on form validation: https://www.javatpoint.com/angular-form-validation-no-whitespace-allowed
Refer to this file in the codebase: src\web\app\pages-help\session-links-recovery\session-links-recovery-page.component.ts, there is an example on how validation is done L39, and you may use the above link in Point 1 to help you too. And this is the page (http://localhost:4200/web/front/help/session-links-recovery): To get to the above page, once you're logged in, in the navbar, click on Help -> Recover Session Links -> Hit on Submit without any input.

Let us know if you have any question.

github-actions[bot] commented 10 months ago

Good First Issue - Notes for Contributors This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

dhanushtheijas08 commented 10 months ago

I would like to work on this issue. Can i go ahead?

domlimm commented 10 months ago

@dhanushtheijas08 Sure thing. Feel free to submit a PR for this issue 👍🏻

rahulpro2001 commented 10 months ago

@domlimm Hi , I am beginner, could I contribute for this issue?

domlimm commented 10 months ago

@rahulpro2001 Hello, please allow @dhanushtheijas08 to work on it first as he has expressed in interest. Feel free to look at other issues tagged with good first issue for the time being!

rahulpro2001 commented 10 months ago

@domlimm okk

ArunErram commented 10 months ago

can i work on these issue please, these is my first open source contribution !

pavanganguru commented 10 months ago

Hi Could any one help me setting up project in my local system, I am getting error at build.properties as null pointer exception. Thanks

cedricongjh commented 10 months ago

can i work on these issue please, these is my first open source contribution !

hi @ArunErram please allow @dhanushtheijas08 to work on it first as he has expressed interest for this issue

cedricongjh commented 10 months ago

hi @pavanganguru, do open a help request here: https://github.com/TEAMMATES/teammates/discussions, it would be good to provide screenshots or more details about the error you're facing as well

IvoHarsani commented 10 months ago

I see that this issue is still open, can I work on it? Also, how can I become a contributor for this repo?

michaelviveiros commented 10 months ago

Posso contribuir com a issue ?

SArora12 commented 10 months ago

Hey! is the issue resolved? If it is still open , i would like to contribute to this issue! Please let me know if I can

domlimm commented 10 months ago

@dhanushtheijas08 Hello, is there any update on this issue? Else, I will ping the next person to attempt it. Thanks!

Afreen97 commented 10 months ago

Hey.I still see this issue open and showing not resolved in my local.Can I take it up?

domlimm commented 10 months ago

@rahulpro2001 Please feel free to submit a PR for this if you're still interested. Else, I will pass it onto the next person. Thank you!

@Afreen97 Let's go down the queue. Feel free to look at other issues tagged good first issue for the time being!

sanjai0py commented 10 months ago

hey @domlimm, i'm also interested in working on this. please add me to the queue.

domlimm commented 10 months ago

@ArunErram @IvoHarsani @michaelviveiros Do let me know if any of you wants to take up this issue.

michaelviveiros commented 10 months ago

@ArunErram @IvoHarsani @michaelviveiros Do let me know if any of you wants to take up this issue.

@domlimm If it's available I would like it.

domlimm commented 10 months ago

@michaelviveiros Hey Michael, feel free to submit a PR for it! Thanks!

ritsam commented 9 months ago

Hello I am a beginner and would like to work on this issue.

domlimm commented 9 months ago

@ritsam Hello, lets give @michaelviveiros some time to work on this. Michael do let us know if you're not working on it anymore.

@ritsam in the meantime, you may look for other good first issue to work on.