[#12954] CreateAccountAction seems to have redundant code

TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education

https://teammatesv4.appspot.com/

GNU General Public License v2.0

1.64k stars 3.26k forks source link

[#12954] CreateAccountAction seems to have redundant code #13039

Closed eraldprifti03 closed 2 months ago

eraldprifti03 commented 2 months ago

Fixes #12954

Outline of Solution Removed reduntant code so it should not be necessary to set the email address, and the institute in this method. Firstly, the account request already has those values. Secondly, those values are also already in the database.

github-actions[bot] commented 2 months ago

Hi @eraldprifti03, thank you for your interest in contributing to TEAMMATES! However, your PR does not appear to follow our contribution guidelines:

Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]
Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

eraldprifti03 commented 2 months ago

Thanks a lot for the collaboration. This was my first OSS contribution, and I'm looking forward to many more.