search

TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education
https://teammatesv4.appspot.com/
GNU General Public License v2.0
1.64k stars 3.26k forks source link

Use AccountRequestUpdateRequest as parameter #13064

Closed ziqing26 closed 2 months ago

ziqing26 commented 2 months ago

Environment: master

Description of feature/enhancement

Currently the AccountRequestUpdate parameters are passed in as separate parameters (see this link).

We want to change it to take in one type as the parameter, instead of passing every parameters in separately. An example of how a type is passed in to represent all parameters: link

Justification

This refactors the code in a more maintainable way, as developers do not need to update the function parameters every time there is a change. Instead, they can just edit the typescript type.

github-actions[bot] commented 2 months ago

Good First Issue - Notes for Contributors This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

SaquibKhanANU commented 2 months ago

Hello, i am interested in attempting this issue

Akshay1018 commented 2 months ago

Hi @ziqing26 if this issue is not assigned to anyone, you can assign it to me. I can take this up. Thanks

ziqing26 commented 2 months ago

Hi @SaquibKhanANU and @Akshay1018 , thank you for your interest. Currently there is an open PR by @Stain19 . If that is not merged but closed in the future, feel free to submit PR but for now you might want to look for another good first issue in TEAMMATES. Thank you:)