13064 use account request update request as parameter

TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education

https://teammatesv4.appspot.com/

GNU General Public License v2.0

1.64k stars 3.26k forks source link

13064 use account request update request as parameter #13070

Closed SaquibKhanANU closed 2 months ago

SaquibKhanANU commented 2 months ago

[#13064] Use AccountRequestUpdateRequest as parameter

Fixes #13064

Outline of Solution Changed input parameter of the editAccountRequest method to AccountRequestUpdateRequest as required. Updated any usages of the editAccountRequest method to pass in the AccountRequestUpdateRequest object.

github-actions[bot] commented 2 months ago

Hi @SaquibKhanANU, thank you for your interest in contributing to TEAMMATES! However, your PR does not appear to follow our contribution guidelines:

Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

weiquu commented 2 months ago

Hi @SaquibKhanANU, I'm closing this PR as there is already an open PR (#13068) addressing this issue. Feel free to open this PR at a later date if the other PR is closed. Do also note that it is common courtesy to check if there are other people working on the issue before jumping in and submitting a PR