[#12679]Name for copied session should not be whitespace

TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education

https://teammatesv4.appspot.com/

GNU General Public License v2.0

1.64k stars 3.26k forks source link

[#12679]Name for copied session should not be whitespace #13072

Closed ArunErram closed 2 months ago

ArunErram commented 2 months ago

Fixes #12679

Outline of Solution

Implemented validation for newFeedbackSessionName input field in the CopySessionModalComponent.ts file. The validation prevents an empty string/ whitespaces from being submitted, ensuring data integrity.

The below is the screenshot of the Expected behaviour(result) for these issue. That Whitespace should not be allowed for the copied session's name. Input validation should not allow whitespaces.

github-actions[bot] commented 2 months ago

Hi @ArunErram, thank you for your interest in contributing to TEAMMATES! However, your PR does not appear to follow our contribution guidelines:

Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

ziqing26 commented 2 months ago

Hi @ArunErram , thanks for the PR, please (1) change the PR title to follow the guideline (2) fix the lint in the failing checks. (Click into the github action below Component Tests /lint for more details).

ArunErram commented 2 months ago

Sure I'll look into it