[#12679] & [#12653] Copying feedback session: Name for copied session should not be whitespace & Copy course modal: Mandatory fields not highlighted

TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education

https://teammatesv4.appspot.com/

GNU General Public License v2.0

1.64k stars 3.26k forks source link

[#12679] & [#12653] Copying feedback session: Name for copied session should not be whitespace & Copy course modal: Mandatory fields not highlighted #13075

Open Josephine0110 opened 2 months ago

Josephine0110 commented 2 months ago

Fixes #12679 Fixes #12653

Outline of Solution

For Issue#12679 Added a validator to copy session component, checking whether the feedback session name is whitespace or not. If the Name for feedback session is only composed of whitespace, the red warning of "The field "Name for copied session" should not be empty." would appear on the screen. Before: (from the issues)

After:

For Issue#12653 Modified frontend to make the user input of Course ID and Course Name mandatory by adding a red warning sign down the input box Before:

After:

github-actions[bot] commented 2 months ago

Hi @Josephine0110, thank you for your interest in contributing to TEAMMATES! However, your PR does not appear to follow our contribution guidelines:

Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

weiquu commented 1 week ago

@Josephine0110 Do fix the failing tests. You can find out more about how to update tests in our documentation

nusoss-bot commented 1 day ago

Folks, This PR seems to be stalling (no activities for the past 7 days). :snail: :cry: Hope someone can get it to move forward again soon...