[#12588] Test coverage improvements for InstructorResponsesViewBase

TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education

https://teammatesv4.appspot.com/

GNU General Public License v2.0

1.65k stars 3.28k forks source link

[#12588] Test coverage improvements for InstructorResponsesViewBase #13087

Closed justinsegawa closed 2 months ago

justinsegawa commented 5 months ago

Part of #12588

I created new units tests for all lines not covered in InstructorResponsesViewBase. Since this is an abstract class I wrote tests in the file per-question-view-responses.component.spec.ts, since PerQuestionViewResponsesComponent extends InstructorResponsesViewBase.

github-actions[bot] commented 5 months ago

Hi @justinsegawa, thank you for your interest in contributing to TEAMMATES! However, your PR does not appear to follow our contribution guidelines:

Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

cedricongjh commented 5 months ago

hi @justinsegawa, thank you for your PR, do ensure that the frontend tests pass before we proceed to review it, it appears that it's currently failing (see component tests, line 183 of per-question-view-responses.component.spec.ts is causing a failure)

nusoss-bot commented 2 months ago

Folks, This PR seems to be stalling (no activities for the past 8 days). :snail: :cry: Hope someone can get it to move forward again soon...