search

TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education
https://teammatesv4.appspot.com/
GNU General Public License v2.0
1.63k stars 3.26k forks source link

[#12901] Added Check for Active Search Service #13136

Closed itstrueitstrueitsrealitsreal closed 6 days ago

itstrueitstrueitsrealitsreal commented 1 week ago

Fixes #12901

Outline of Solution

As discussed in the issue, I added a check for an active search service before the rest of AccountRequestsDbIT::testSqlInjectionSearchAccountsRequestsInWholeSystem ran, but I did not shift the test to AccountRequestSearchIT as the test utilised methods from the accountRequestDb class, which I feel should not be put into AccountRequestsDbIT as it has tests which make use of database related functionality.

weiquu commented 6 days ago

Merged https://github.com/TEAMMATES/teammates/pull/13101 as it came first