[#12552] Session Copy Modal: Instructors able to select the Course that they are copying from

TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education

https://teammatesv4.appspot.com/

GNU General Public License v2.0

1.66k stars 3.28k forks source link

[#12552] Session Copy Modal: Instructors able to select the Course that they are copying from #13149

Open Respirayson opened 2 months ago

Respirayson commented 2 months ago

Fixes #12552

Outline of Solution To fix this issue, whenever the instructor selects the same course that the feedback session belongs to, there'll be an alert that pops up to say that there already exists a session with the same name in that course.

https://github.com/user-attachments/assets/8ec32680-4c65-42c0-9541-8c9fe91b4861

domoberzin commented 2 months ago

I think standardizing the copies to have 'Copy of' prepended by default is okay, since the instructor would be able to edit this name in the modal, but @damithc would you like to weigh in on this change?

mingyuanc commented 2 months ago

@damithc Prof any updates?

damithc commented 2 months ago

Hmm... Google docs allows the user to change the session name later, but we don't allow users to change the session name later. So, this strategy can lead to more severe problems than the current issue which is a mere inconvenience. For example, the user might not realize the name was prepended with a 'Copy of' until much later, when it is too late to even delete it. So, I prefer to keep the same session name unless the user changes it but prompt the user to change it when we detect a likely name collision e.g., if the name and course is same as the original, show a red warning message somewhere in the copy dialog. Is that feasible?

domoberzin commented 2 months ago

@damithc thanks for the input Prof, I think that's a fair approach to take for this

@Respirayson could you implement it as described above? So there shouldn't be a 'Copy of' prepended but rather a warning/error within the popup when the name and course are the same

nusoss-bot commented 1 month ago

Folks, This PR seems to be stalling (no activities for the past 8 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot commented 1 month ago

Folks, This PR seems to be stalling (no activities for the past 7 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot commented 1 month ago

Folks, This PR seems to be stalling (no activities for the past 13 days). :snail: :cry: Hope someone can get it to move forward again soon...