TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education
https://teammatesv4.appspot.com/
GNU General Public License v2.0
1.66k stars 3.28k forks source link

Failing component test #13173

Open weiquu opened 1 month ago

weiquu commented 1 month ago

The SearchAccountRequestsActionTest has suddenly started failing... did a quick check and couldn't find any recent code change that caused it. The tests are failing due to this error: java.lang.IllegalArgumentException: UUID string too large, from the same method. Example stack trace:

java.lang.IllegalArgumentException: UUID string too large
    at java.util.UUID.fromString(UUID.java:199)
    at teammates.storage.sqlsearch.AccountRequestSearchManager.getEntityFromDocument(AccountRequestSearchManager.java:39)
    at teammates.storage.sqlsearch.AccountRequestSearchManager.getEntityFromDocument(AccountRequestSearchManager.java:19)
    at teammates.storage.sqlsearch.SearchManager.convertDocumentToEntities(SearchManager.java:220)
    at teammates.storage.sqlsearch.AccountRequestSearchManager.searchAccountRequests(AccountRequestSearchManager.java:56)
    at teammates.storage.sqlapi.AccountRequestsDb.searchAccountRequestsInWholeSystem(AccountRequestsDb.java:187)
    at teammates.sqllogic.core.AccountRequestsLogic.searchAccountRequestsInWholeSystem(AccountRequestsLogic.java:182)
    at teammates.sqllogic.api.Logic.searchAccountRequestsInWholeSystem(Logic.java:1712)
    at teammates.ui.webapi.SearchAccountRequestsAction.execute(SearchAccountRequestsAction.java:24)
    at teammates.ui.webapi.SearchAccountRequestsAction.execute(SearchAccountRequestsAction.java:16)
    at teammates.ui.webapi.BaseActionTest.getJsonResult(BaseActionTest.java:571)
    at teammates.ui.webapi.BaseActionTest.getJsonResult(BaseActionTest.java:561)
    at teammates.ui.webapi.SearchAccountRequestsActionTest.testExecute_searchName_shouldSucceed(SearchAccountRequestsActionTest.java:94)
    ...

Might be related to this PR, but needs more investigation: https://github.com/TEAMMATES/teammates/pull/12950. Could also be a setup issue on the database or data bundle side.

Putting as p.High since we should really ensure all tests are passing...