search

TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education
https://teammatesv4.appspot.com/
GNU General Public License v2.0
1.65k stars 3.28k forks source link

AdminHomePageUiTest fails in dev #2381

Closed thyageshm closed 10 years ago

thyageshm commented 10 years ago

There are 8 html verification tests that fail across various pages (stats obtained from godmode).

thyageshm commented 10 years ago

@franklingu, the test fails after this commit: ('dev green' on 8 Aug 13:17) and when this was merged into dev, commit: 652cf61871c042995327c44e042c45ca151b19a9 [652cf61]

I think it was because you forgot to remove godmode from StudentHomePageUiTest commit: 67b74c655df8a655cab727b1c9656ad2cda0b25c [67b74c6]

damithc commented 10 years ago

Fails on my side too. I thought it's something to do with legacy data in my datastore.

franklingu commented 10 years ago

@thyageshm , 1.that is removed in the comment following 2.it is a better idea to give which line(s) which html(s)

franklingu commented 10 years ago

and from what i am seeing now, fails on dev are not just from studenthomepage.

thyageshm commented 10 years ago

I see... are there many that fail? Cos my last push passed all except for AdminHomePageUiTest. I am running it now

franklingu commented 10 years ago

sorry dude...I just run studentHomePageUiTest and adminHomePageUitest. and then applied the fix

franklingu commented 10 years ago

see if it is alright for you now. close this issue if the fix is working?

thyageshm commented 10 years ago

Nope, it still fails. The latest dev fails on line 194 (newlyJoinedInstructorCommentsPage.html)

franklingu commented 10 years ago

do you mind giving me some more info? cause it is fine on my comp. do not what is wrong

franklingu commented 10 years ago

and just to make sure, L183 is commentsPage.html. are we talking about the same dev?

franklingu commented 10 years ago

I think on master it is failing though. instructorcommentsPage in adminthomepageuitest

thyageshm commented 10 years ago

I have made the necessary changes to it on dev. Now running all tests to make it dev green

thyageshm commented 10 years ago

Ok, this and other small test failures after merging master into dev have been fixed. It is green on my computer, could you help me run it on your side? I will run it on my staging server tomorrow

franklingu commented 10 years ago

fails on my comp. adminHomePageUiTest. definitely something is wrong. we can fix this together with #2402

thyageshm commented 10 years ago

could you send me the expected vs actual html over email? thanx!

franklingu commented 10 years ago

the frc should be in actual, but it does not show up for me--which is just weird. the expected html is right, just that my comp generates wrong output

Gu Junchao Major in Computer Engineering, National University of Singapore Primary Email: franklingujunchao@gmail.com franklingujunchao@gmail.com NUS Email: A0105750@nus.edu.sg A0105750@nus.edu.sg

On Tue, Aug 12, 2014 at 11:52 PM, thyageshm notifications@github.com wrote:

could you send me the expected vs actual html over email? thanx!

— Reply to this email directly or view it on GitHub https://github.com/TEAMMATES/repo/issues/2381#issuecomment-51934173.

thyageshm commented 10 years ago

ok. Kai got it to pass on his comp as well. I am running it on the staging server now