search

TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education
https://teammatesv4.appspot.com/
GNU General Public License v2.0
1.66k stars 3.29k forks source link

Remove unused parameter studentEmail in getQuestionResultStatisticsHtml method #6677

Closed AnaghHegde closed 7 years ago

AnaghHegde commented 7 years ago

The getQuestionResultStatisticsHtml() method of FeedbackMsqQuestionDetails.java class contains an unused parameter String studentEmail .

AnaghHegde commented 7 years ago

I think it can be a d.FirstTimers issue.

wkurniawan07 commented 7 years ago

I am sure this is not the case. The method is annotated with @Override.

AnaghHegde commented 7 years ago

But its not being used anywhere in the some classes like FeedbackMsqQuestionDetails.

wkurniawan07 commented 7 years ago

@AnaghHegde, take some time to read up on Java's @Override annotation. If you actually remove the said parameter from the function, I can guarantee you a compile error.