AboutUs page: add back numbering

[damithc]

v5.112 Numbering seems to have disappeared. Actual: Expected:

[wkurniawan07]

I'm pretty sure they have disappeared as far back as when the front pages adopts a responsive design, #6488.

[wkurniawan07]

Anyway, looks like this is good time to realize #6731. Otherwise anytime we want to change the design of this page, it has to be duplicated 200+ times.

Cue @whipermr5 @thenaesh (to review my incoming PR).

[damithc]

I'm pretty sure they have disappeared as far back as when the front pages adopts a responsive design,

I checked. It is fine even in the current live version v5.111. Broke in the v5.112 (yet to be deployed)

[ncbaihly]

I took a brief look at this as I was looking for a first time PR. @wkurniawan07 might have this handled but, the issue is the CSS child selector for the ordered table class.

The current CSS is:

.ordered-table > tr:not(.skip) {
    counter-increment: rownumber;
}

.ordered-table > tr > td:first-child::before {
    content: counter(rownumber) '.';
    margin-right: .5em;
    min-width: 1em;
}

The problem with > is that it means only immediate descendants which is why this is not working.

Just having the tag after a class is also a descendant selector, but it can be any descendant further down in the tree, not strictly an immediate descendant.

Thus if we change it to the following it works as intended:

.ordered-table tr:not(.skip) {
    counter-increment: rownumber;
}

.ordered-table tr > td:first-child::before {
    content: counter(rownumber) '.';
    margin-right: .5em;
    min-width: 1em;
}

EDIT: I feel like I should maybe clarify, they look like direct descendants when you are looking at the code, but when the browser builds the DOM it puts the <tr> tags inside of a <tbody>(tbody tag is required for tables) making them not direct descendants and breaking the styling.

[wkurniawan07]

@ncbaihly good job in troubleshooting! However, I'm currently preparing something that may invalidate this issue, so you may want to pick another d.FirstTimers-labelled issue to work on.

[shaharyar-shamshi]

Sir I want to give suggestion to solve this issue . If we store the user info (making separate class having the instances of user name and contribution) and iterate through it using JSP code then number can be added efficiently and also making About us page source code compact EL can be used to extract the instances. I am very eager to work on it to solve this issue . Even MVC model can solve this @wkurniawan07 sir if you allow me I can work on it

[shaharyar-shamshi]

@wkurniawan07 sir can I work on this if u allow me

[wkurniawan07]

Hi @shaharyar-shamshi, thanks for your suggestion. Unfortunately, I have already done enough works to solve the issue at hand. You may wish to find other issues (particularly those labelled d.Contributors) to work on.