TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education
https://teammatesv4.appspot.com/
GNU General Public License v2.0
1.67k stars 3.3k forks source link

InstructorFeedbackResultsPage: make span scrollable to fit the table to copy #8437

Closed joanneong closed 4 years ago

joanneong commented 6 years ago

Description of feature/enhancement

In the instructor feedback results page, instructors can directly copy the data in the page to an excel spreadsheet if non-english characters are not displayed properly in the downloaded file:

image

However, if there are feedback and comments given by students/instructors, the resulting table protrudes from the given span:

image

The span can be made scrollable in order to fit the entire table within the span.

Justification

By allowing the table to fit within the span, it will improve the look of the table. Additionally, it will make the table more readable for instructors (particularly the alternating transparent rows) so that they can take a look at the data before copying to their excel spreadsheet.

lightt77 commented 6 years ago

I would like to work on this one...

joanneong commented 6 years ago

@lightt77 Since you are new to TEAMMATES, it is recommended that you try a d.FirstTimers issue first before moving on to a d.Contributors issue like this one :)

shivanshsoni commented 6 years ago

@joanneong I would like to work on this issue....Is it possible?

lightt77 commented 6 years ago

@joanneong Okay, I'll do that first.

joanneong commented 6 years ago

@shivanshsoni Since you have already tried a d.FirstTimers issue, feel free to give this a shot :)

shivanshsoni commented 6 years ago

ok :-)

Shashwat-Garg commented 6 years ago

@shivanshsoni Are you working on this issue ?

Shashwat-Garg commented 6 years ago

@joanneong Can we add it to the stylesheet to make changes ? I've tried it and it works. Should I proceed with a PR, or should I try it some other way ?

joanneong commented 6 years ago

@Shashwat-Garg You can go ahead and open a pull request first, and we will see how to proceed from there :)

wkurniawan07 commented 4 years ago

Closing as the modal to show table has been deprecated.