TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education
https://teammatesv4.appspot.com/
GNU General Public License v2.0
1.66k stars 3.29k forks source link

InstructorHelp: Fix inconsistent indentation for different sections #8675

Closed joanneong closed 6 years ago

joanneong commented 6 years ago

A typical section in the instructor help page should look like this:

screen shot 2018-03-19 at 12 42 33 am

However, the later sections (from "Profiles" onwards) look like this:

screen shot 2018-03-19 at 12 43 03 am

Although it cannot really be seen from the screen captures, these later sections are at a different indentation level (headers and content) from the preceding sections.

Expected behaviour

Since the sections are at the same level within the instructor help page, they should have the same amount of indentation as well for a consistent UI.

Additional info

Given that the instructor help page is set to undergo some drastic changes, is it worth making this a legit d.FirstTimers issue to work on?

@craaaa , can I have your input on this?

craaaa commented 6 years ago

Good catch! I don't think it's that worth it though. We will likely be moving away from displaying questions as a list, so any changes made here are likely to be undone soon.

sukanta-27 commented 6 years ago

@craaaa

We will likely be moving away from displaying questions as a list,

Just out of curiosity, what do you mean by this?

craaaa commented 6 years ago

@sukanta-27 As part of #8504, I'm thinking of making some design changes to instructorHelp.jsp so it will be more easy to skim for answers. Some possible changes are using accordions or collapsed sections, or moving content into multiple separate pages. Doing so will require reorganizing the section structure, so changes made to fix this issue are likely to be overwritten.

craaaa commented 6 years ago

Closing as the issue will be fixed alongside #8635.