Microsoft Visual Studio could be installed in different locations

TEAMuP-dev / HARP

A sample editing application allowing for hosted, asynchronous, remote processing of audio with machine learning by routing through Gradio endpoints.

BSD 3-Clause "New" or "Revised" License

27 stars 1 forks source link

Microsoft Visual Studio could be installed in different locations #173

Open NathanPruyne opened 2 months ago

NathanPruyne commented 2 months ago

To build locally on Windows 10, I had to change line 148 of CMakeLists.txt to make the path point to C:/Program Files (x86)/... rather than C:/Program Files/... because of where my Visual Studio instance decided to install itself. I'm not sure if this is the same on all systems so I don't think this should be pushed as a change but it is an inconsistency.

xribene commented 2 months ago

I'm guessing this is because you are not running VS 2022. Older versions are only 32bit I think so by default, on a 64bit machine, they are installed in Program Files(x86). One possible solution would be to

a) Detect the windows architecture (32 vs 64bit)
b) Get the VS version using the MSVC_VERSION variable

Based on these two we can set the correct path for VS. There might be other better ways to do it though.