TEC-Toolkit / ECFO

The Emission Conversion Factor Ontology
https://w3id.org/ecfo
Other
1 stars 0 forks source link

Remove "specification draft" #11

Closed dgarijo closed 1 year ago

dgarijo commented 1 year ago

Now they are releases

inaja commented 1 year ago

I am editing the files for the w3id site, I will remove the specification draft and put 'release'. but the 'this' instances referring to our affiliations are showing up with the other instances. Do I just remove them manually myself ?

dgarijo commented 1 year ago

Please do not remove "this" from instances, because that's a good practice.

The specification draft is a label that can be changed in the html. Please change it to just "TEC Toolkit specification"

El mar., 2 may. 2023 10:33 p. m., Iman Naja @.***> escribió:

I am editing the files for the w3id site, I will remove the specification draft. but the 'this' instances referring to our affiliations are showing up with the other instances. Do I just remove them manually myself ?

— Reply to this email directly, view it on GitHub https://github.com/TEC-Toolkit/ECFO/issues/11#issuecomment-1532111679, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALTIGSFVC6IHQOSW7VJZ43XEFVRJANCNFSM6AAAAAAXSJLNTA . You are receiving this because you were assigned.Message ID: @.***>

inaja commented 1 year ago

OK I wont remove the this, but the websites of the universities are showing up in Table 1 (Namespaces used in the document)

dgarijo commented 1 year ago

Ah they can be removed from there indeed. I thought you meant in the ontology

El mar., 2 may. 2023 10:38 p. m., Iman Naja @.***> escribió:

OK I wont remove the this, but the websites of the universities are showing up in Table 1 (Namespaces used in the document)

— Reply to this email directly, view it on GitHub https://github.com/TEC-Toolkit/ECFO/issues/11#issuecomment-1532117793, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALTIGSZQYFIYROQCL5BHWDXEFWETANCNFSM6AAAAAAXSJLNTA . You are receiving this because you were assigned.Message ID: @.***>

inaja commented 1 year ago

Also, just for clarification... I didnt mean to remove the 'this' from the ontology itself, I meant to remove the 'this' from the section of the instances in the w3id website. but if it is good practice then i wont touch the instances section of the website code

dgarijo commented 1 year ago

They are correct in that section. The instances include "#this" because the url sof the respective institutions are not technically entities

El mar., 2 may. 2023 10:41 p. m., Iman Naja @.***> escribió:

Also, just for clarification... I didnt mean to remove the 'this' from the ontology itself, I meant to remove the 'this' from the section of the instances in the w3id website. but if it is good practice then i wont touch the instances section of the website code

— Reply to this email directly, view it on GitHub https://github.com/TEC-Toolkit/ECFO/issues/11#issuecomment-1532121236, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALTIGUT2IX3E2GMA2DL7ADXEFWPRANCNFSM6AAAAAAXSJLNTA . You are receiving this because you were assigned.Message ID: @.***>

stefanogermano commented 1 year ago

I think there was a misunderstanding on this. We discussed it during our meeting on Tuesday.

PECO: image

ECFO: image

It is easy to see that there is something wrong (at least in one of them). This should be fixed.

dgarijo commented 1 year ago

Why did this happen :D

dgarijo commented 1 year ago

This was due to wrong annotations in the instances. I changed them