search

TECH7Fox / asterisk-hass-integration

Asterisk integration for Home Assistant
57 stars 13 forks source link

fix issue where pjsip_loaded and sip_loaded flags are never both true #88

Closed mitchmitchell closed 1 year ago

mitchmitchell commented 1 year ago

in the may 8th commit, a bug was introduced where both pjsip_loaded and sip_loaded must be true to complete creating devices but these values, while set locally, are never written back into hass.data so both are never true at the same time.

TECH7Fox commented 1 year ago

Did you test this?

The CI fails because of the manifest order. Except for some, it should be in an alphabetical order.

mitchmitchell commented 1 year ago

It’s running on my system now, the reference didn’t mention alphabetical order regarding the manifest keys but it’s easy to change. I’ll see if I can remove that part of the PR.

Sent from my iPad

On Jun 16, 2023, at 2:07 AM, Jordy Kuhne @.***> wrote:



Did you test this?

The CI fails because of the manifest order. Except for some, it should be in an alphabetical order.

— Reply to this email directly, view it on GitHubhttps://github.com/TECH7Fox/asterisk-hass-integration/pull/88#issuecomment-1594211838, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAMRIRJ5DU76ACKYWXGM4YDXLQA35ANCNFSM6AAAAAAZITMDA4. You are receiving this because you authored the thread.Message ID: @.***>

mitchmitchell commented 1 year ago

I've placed the logger attribute in the correct order, see if it passes now.

TECH7Fox commented 1 year ago

Looks good now. Will merge and release when I get home. Thanks @mitchmitchell!