search

TECHNOVE / Airplane

A stable, optimized, well supported 1.17.1 Paper fork.
https://airplane.gg
GNU General Public License v3.0
344 stars 99 forks source link

speed up build times #43

Closed Toffikk closed 3 years ago

Titaniumtown commented 3 years ago

How does this speed up build times?

PaulBGD commented 3 years ago

Maybe the incremental part? I'm not familiar with it though.

jpenilla commented 3 years ago

Configuring UTF-8 encoding for Javadoc and ProcessResources is not a bad idea, however this PR does absolutely nothing whatsoever in terms of improving build times. In fact, this PR will probably slow down build times by forcing a fork and applying the java plugin to the root project where before it was only applied to subprojects.

jpenilla commented 3 years ago

Maybe the incremental part? I'm not familiar with it though.

It defaults to true. There is no need to set it manually.

Toffikk commented 3 years ago

Configuring UTF-8 encoding for Javadoc and ProcessResources is not a bad idea, however this PR does absolutely nothing whatsoever in terms of improving build times. In fact, this PR will probably slow down build times by forcing a fork and applying the java plugin to the root project where before it was only applied to subprojects.

The Java plugin was applied to the root project before too, and forcing a fork can speed up the build times in some cases

jpenilla commented 3 years ago

I hadn't noticed it was applied to the root project, although it shouldn't be necessary to apply there, as the root project does not compile any java sources. It's possible paperweight is using it for something, I don't remember off the top of my head.

Regardless, it doesn't answer the question of why you are changing that block to apply to allprojects instead of subprojects. Those repositories and the java plugin don't need to be configured for the root project as it doesn't compile any java sources or pull anything from those repositories. I assume maybe it's because you want your changes to the java plugin to apply to the root project, but like I mentioned already it doesn't compile any java sources.

I also highly doubt that forcing a new process to be forked regardless of whether it's necessary will speed things up, feel free to provide a benchmark, or elaborate on what you mean by "in some cases" though.

PaulBGD commented 3 years ago

Unconvinced this improves things, please benchmark it from a clean build.

PaulBGD commented 3 years ago

Closing due to lack of a response.