search

TECHNOVE / Airplane

A stable, optimized, well supported 1.17.1 Paper fork.
https://airplane.gg
GNU General Public License v3.0
344 stars 99 forks source link

Flare profiler overrides any plugins /profile commands #51

Closed viomck closed 2 years ago

viomck commented 3 years ago

An easy enough solution would be to disable Flare commands when web token is nothing... but does anyone even use the profile alias? I feel like we could pretty easily just remove any generic aliases and stick with /flare.

My vote is to just remove the /profile alias, but either solution will work. Can PR if needed.

Relevant line is https://github.com/TECHNOVE/Airplane/blob/ver/1.17/patches/server/0014-Airplane-Profiler.patch#L260

Internal ticket reference: 0413

/cc @PaulBGD

PaulBGD commented 3 years ago

Already fixed on 1.17, could be backported.

viomck commented 3 years ago

Already fixed on 1.17, could be backported.

Which commit fixes this in 1.17?

PaulBGD commented 3 years ago

https://github.com/TECHNOVE/Airplane/commit/1d2c66417564f6e21471522a45233bfff5aa495f

viomck commented 3 years ago

I see

+        // todo lookup token (off-thread) and let users know if their token is valid
+        if (accessToken.length() > 0) {

& personally don't think there'd be any issue merging this line but just checking do you know of anything 1.16 -> 1.17 that would affect this or should I be good to use the same method?

PaulBGD commented 3 years ago

That's all it is, except if you copy the code exactly note that I accidentally did the null check wrong haha

PaulBGD commented 2 years ago

I'll be honest, 1.16 isn't super top priority. We'd accept a PR, but I don't think it's something I'd add right now.