TECHS-Technological-Solutions / ocpi

Python implementation of the Open Charge Point Interface (OCPI)
MIT License
49 stars 15 forks source link

Fixing credentials module endpoint retreival #54

Open arno1820 opened 1 year ago

arno1820 commented 1 year ago

https://github.com/TECHS-Technological-Solutions/ocpi/issues/53

In regards to this issue, I propose the following fix.

Both in the POST as the PUT the issue was present. With PUT it was breaking, with POST it would save all present in the data-object (so also the 'version' field) of the request body.

Added a test that tests the sunny day case of this implementation.

HamedAkhavan commented 1 year ago

@arno1820 please rebase to develop

VictorTechs commented 1 month ago

Hello @arno1820, Sorry for long response, could you rebase your PR to develop?