search

TED-inc / FabricQuarry

An addon for Tech Reborn. This mod add Quarry which will mine ores in specific radius, and consumes energy
https://www.curseforge.com/minecraft/mc-mods/quarry-reborn
11 stars 14 forks source link

[bug | 0.5.0] Quarry upgrades getting deleted #26

Closed Link250 closed 2 years ago

Link250 commented 2 years ago

Description When breaking the Quarry, any Quarry Upgrades like Silk Touch or Fortune get destroyed while other Upgrades like Overclocker or Transformer get dropped. (Might be related but hasn't been tested) After a Server restart these Upgrades were also missing from the quarry and it's progress was reset, causing it to start mining through it's own tubes again, destroying the previously placed tubes in the process.

To Reproduce Simply place any Quarry Upgrades into their special slots and break the Quarry with a suitable pickaxe.

Expected behavior The Quarry Upgrades should be dropped as Items just like the other Upgrades or blocks inside the Quarry get dropped when breaking it.

Mods versions:

TED-inc commented 2 years ago

Thx for detailed report, I will look on it.

TED-inc commented 2 years ago

Could u write more detailed about

After a Server restart these Upgrades were also missing from the quarry and it's progress was reset, causing it to start mining through it's own tubes again, destroying the previously placed tubes in the process.

I can't reproduce it

TED-inc commented 2 years ago

Main issue fixed in 0.5.1

Link250 commented 2 years ago

Thank you very much for the fix !

About the other Issue: I just set up a completely fresh 1.17.1 Server with Fabric 0.11.7 and only these mods:

I filled up a Quarry with a Silk Touch Upgrade, Overclocker Upgrade, Stone as Filler Blocks, Tubes and powered it with an Ultimate Solar Panel 2021-10-31_18 14 42 Then i stopped the Server with the "stop" command and after starting it back up again the Quarry was missing all the items.

TED-inc commented 2 years ago

Could you test it with some other blocks from tech reborn? Like matter fabricator, or compressor. Are they have similar issues?

TED-inc commented 2 years ago

Maybe your world just don't save? U can check it, by adding items in your inventory, save world, then put them in quarry and stop server. If after restart your items will be in your inventory - this just mean that world wasn't saved

Link250 commented 2 years ago

Other tech reborn blocks seem to be fine (Tested Matter Fabricator, Compressor and Electric Furnace) and my inventory and other blocks in the world get saved too, only the Quarry is affected. Also i noticed some warnings in the server log that might be relevant and help finding the cause (https://pastebin.com/Wk5fEPEx), especially lines 59 and 83.

TED-inc commented 2 years ago

I think problem is in line 83

TED-inc commented 2 years ago

Could you try previous version of quarry mod (fe 0.4.4). Is it have similar issue?

Link250 commented 2 years ago

Tried using 0.4.4 and it had the same problem (https://pastebin.com/iUMMbwhs) i also made sure to create a new world and such to test it with in case the old one still had any issues.

itsdinkd commented 2 years ago

Items are getting deleted when server restarts or you leave your world.

TED-inc commented 2 years ago

@red2blue U can reproduce it in single player? Do you have a steps to reproduce?

TED-inc commented 2 years ago

I finally found solution, so it fixed in 0.5.2 🎉. Please, check it

Link250 commented 2 years ago

That seems to have fixed the issue for me, thank you very much !