search

TEHIK-EE / tedi-design-system

TEDI is TEHIK design system
4 stars 12 forks source link

Text field #234

Open airikej opened 1 month ago

airikej commented 1 month ago

https://github.com/TEHIK-EE/tedi-design-system/issues/119

Figma?node-id=3486-37651&m=dev)

Dependencies:

No API changes but would suggest this:

kasparsuvi1 commented 1 month ago

Merge onChange and onChangeEvent: This can simplify the API by having a single prop that supports both use cases. Most common cases use onChange, because there is nothing else but value needed from the event. But there are some usecases where event is needed, for that purpose i think both should be available.

airikej commented 2 weeks ago

@kasparsuvi1 @HarlesPilter is TextField with clearing button used anywhere else than just as search input? The designers want to break them into 2 components, so TextField wouldn't be having either large variant and also clearable button - they would be exclusive to Search component later. What do you think about that?