search

TEHIK-EE / terminology-migration

The aim of this repository is to define the strategy of terminology handling and to migrate today's codesystems to terminology server
1 stars 0 forks source link

First batch migration issues/questions #25

Closed rlindstrm closed 9 months ago

rlindstrm commented 1 year ago

I'm not feeling smart at all, so these are questions and a reflection of my inner confusion.

1) Should they be requestable from TermX server? I did not manage. 'https://termx.kodality.dev/api/fhir/CodeSystem/abivahendid-funktsioonide-toetamiseks--1' resulted in 403 "abivahendid-funktsioonide-toetamiseks.CodeSystem.read not allowed"

2) Should the CS or VS id always contain version number? It does right now.

3) All dates include date and time, but I'm not sure we want time. "date": "2016-05-27T00:00:00Z" is maybe reasonable to have time, but effectiveDates would probably look cleaner without time.

4) ValueSet using codesystem supplement. SNOMED has property "parent". With supplement we assigned new parents. The value set expansion seems to include the correct parents, but I don't know why. If the base SNOMED and supplement both assign parents, shouldn't it take all parents from both? I assumed it would and suggested GroupedBy attribute rather than "parent", so I am a little confused why it seems to work with just "parent". Is it because you have pre-defined the expansion? Isn't that risky?

5) Hierachy meaning by default is is-a. Should I correct manually when I want something else? "https://fhir.ee/CodeSystem/apgari-komponendid" for example clearly has grouped-by (changed it in TermX, but not sure if that is the best way to go).

rlindstrm commented 1 year ago
  1. I've managed to mix up Terviseamet and Tervisekassa as endorser for all the ER_... value sets. Should I fix in the file or manually or both?
rlindstrm commented 1 year ago
  1. Display seems to be listed as one of the properties in json. I'm not sure that's correct.
  2. Right now, the language of the CS resource is the default language of any display name that is used in the CS. Is that sufficient, or should every display name also have a language tag? Just in case we would have more languages per one code some time in the future.
igorboss commented 1 year ago

"1. We reconfigured server and by default access is profibited to the all CS and VS. Please authorize first, I'll reconfigure server later. "2. Yes, version number should be in the id. The Ontoserver use uuid for that, but I think that combination of id of CS/VS + version number is more informative. "3. Depends on datatype. Most datetime/timestamp requires TZ also. "4,5,6. Lets discuss it on Monday. "7. This is decision point. We can made it configurable. "8. Yes, every display have own language tag. You can changed preferred language for every version.

rlindstrm commented 1 year ago
  1. for further testing, also in Ontoserver
  2. fix manually, mark a comment in table
  3. fix in table