search

TEHIK-EE / terminology-migration

The aim of this repository is to define the strategy of terminology handling and to migrate today's codesystems to terminology server
1 stars 0 forks source link

ValueSet should only contain active elements #36

Closed rlindstrm closed 9 months ago

rlindstrm commented 12 months ago

Value sets should only contain concepts that are marked active in current version in pubkeskus.

ValueSet can contain elements that are inactive in source CodeSystem, but it's highly unusual. ValueSet cannot contain elements that don't exist in CodeSystem. For local CodeSystems, that are created from pubkeskus file, the CodeSystem should include all concepts (including the ones that are marked Status=0), but ValueSet should include only the concepts that are active in CodeSystem.

rlindstrm commented 10 months ago

Currently, expansion does not work at all when codesystem is in draft status. That is problematic for value sets in planning status, because normally you would publish the codesystem and valueset together.

igorboss commented 10 months ago

It because the concepts in status draft are inactive. If you select show inactive concepts the expansion will work. Please review how Ontoserver works with draft concepts

rlindstrm commented 10 months ago

New try. @marinaivnv I have added Status back to those rows where new import is needed to fix the data. 1) Please re-migrate rows where migration status = 6 or 2 2) Do not add EffectiveDate and RetirementDate in the codesystem (there were many errors with date formats, and it's redundant data - let's try without it) 3) Add Status in the codesystem 4) If possible, check if status matches the dates in the original source (if Kehtivuse_lõpu_kpv is filled in, Staatus should be 0). 5) For codesystems, import inactive concepts as well. 6) For valuesets import only active concepts.

I hope it fixes most of the errors we have right now.

marinaivnv commented 10 months ago

@rlindstrm import is done

rlindstrm commented 9 months ago

rhd-kuuluvus--4
ValueSet based straight on SNOMED CT still includes concepts that are inactive in pubkeskus csv. They are still active in the code system, so they should just not be imported at all.

marinaivnv commented 9 months ago

@rlindstrm reimport is done

rlindstrm commented 9 months ago

For this one, or all the ones that don't have CS or CS supplement defined in the table? Rhd-kuuluvus is ok.

marinaivnv commented 9 months ago

For all that don't have CS or CS supplement defined in the table.

rlindstrm commented 9 months ago

Mostly OK. Remaining issues filed separately.