search

TEI-Music-SIG / MEItoVexFlow

JavaScript libray to render MEI notation using VexFlow
20 stars 9 forks source link

adapt to changed Vex.Log functions #23

Closed bwbohl closed 10 years ago

bwbohl commented 10 years ago

Vex.Log Vex.LogInfo Vex.LogDebug etc.

have changed and MEItoVexFlow tests will fail due to this.

bwbohl commented 10 years ago

run '''bower update''' to fetch new vexflow buid and see yourself ;-)

bwbohl commented 10 years ago

ok started working on this. Actually all we've got to do is replace the Vex.LogXX function with Vex.L(block, params)

Where block can be a string and params will be an array of any number of items

aerhard commented 10 years ago

hey Benjamin, thanks -- i changes my branch accordingly. I think there is one more thing: there is no more Vex.DebugLevel, so we have to change the way log messages are turned on/of in MEI2VF. An easy way to do it would be to just do it like in the latest VexFlow files: add a function L to MEI2VF to which all MEI2VF messages are sent. Depending on a boolean variable in MEI2VF, these messages get either sent to VexFlow' "L" or not. See my proposal at https://github.com/aerhard/MEItoVexFlow/blob/master/src/main.js#L17 and https://github.com/aerhard/MEItoVexFlow/blob/master/src/main.js#L5-L9

raffazizzi commented 10 years ago

I think this is resolved now, please reopen if I'm wrong.