Make savePosition and restorePosition optional behavior

TEIC / CETEIcean

TEI in HTML5 Custom Elements

BSD 2-Clause "Simplified" License

164 stars 36 forks source link

Make savePosition and restorePosition optional behavior #24

Closed raffazizzi closed 4 years ago

raffazizzi commented 4 years ago

I think these functions that parse a ulr fragment (window.location.hash) to scroll an ID into view should not be a core behavior of CETEIcean. URL fragments serve a variety of functions in modern webapps (especially one page apps) and this code can get in the way. I would suggest to make it optional, e.g. via a parameter at instantiation. Thoughts? https://github.com/TEIC/CETEIcean/blob/master/src/CETEI.js#L682

raffazizzi commented 4 years ago

PR https://github.com/TEIC/CETEIcean/pull/23/commits/04955da75e8eb3b2d8d7f39cabe6be21de86e50f would be affected, but we can integrate the suggested change if we decide to make it optional, or even parametrize the requested unicode support (though I don't see why it shouldn't be supported in all cases).