search

TEIC / Roma-Antiqua

This repository houses the code for Roma Antiqua, the web based TEI software for generating customisations.
https://romaantiqua.tei-c.org
20 stars 7 forks source link

Use the base name of the odd file to create the compiled version rather than the full path. #2

Closed lddubeau closed 10 years ago

lddubeau commented 10 years ago

Previously:

$ roma2 --compile long/path/to/somewhere.xml out

would create a compiled file at out/long/path/to/somewhere.xml.compiled. The modification makes it so that the compiled file is at out/somewhere.xml.compiled.

This is also fun:

$ cd out
$ roma2 --compile ../myTEI.xml .  # compiled version stored at ../myTEI.xml.compiled

I've not noticed a test suite. It would not hurt to inspect, run or test somehow this proposed modification before merging.

lddubeau commented 10 years ago

Anything more I need to do to see it merged?

lddubeau commented 9 years ago

Is it the case that there has not yet been a deb release with this patch? The latest tei-roma release I see here dates from July 2013 but this patch was merged Jan 2014.

lddubeau commented 9 years ago

There may be a bug with the fix I've suggested. Namely, it may be better to use $schema rather than $ODDBASE.

When I produced the fix it so happened that $schema and $ODDBASE were identical in the project I was working on, and I keep forgetting that roma bases the file names it outputs on the schema name than on the odd file name itself. So I did not see the problem. But I've just modified the file naming convention for a project where I want to have odd files named by version and got the surprise of seeing the version number show up in the name of the .compiled file.

sebastianrahtz commented 9 years ago

that does sound better, using $schema. I'll do that and make a new .deb release in a mo.