search

TEIC / Stylesheets

TEI XSL Stylesheets
234 stars 125 forks source link

Don't use content of tei:index in tei:head #475

Closed dmj closed 2 years ago

dmj commented 4 years ago

Fix #382

sydb commented 4 years ago

David — I don’t suppose you have a test case that demonstrates <index> inside <head> as being problematic?

dmj commented 4 years ago

Not yet, I suppose. How does a test case look like? I think I can come up with one for the Makefile based tests, the Ant-based is still a mistery to me.

martindholmes commented 4 years ago

@dmj Don't worry about Test2; @sydb and I will take care of that. Although if you want to learn how it works, there's some decent documentation. Try running ant -projecthelp | less in the Test2 folder.

sydb commented 4 years ago

Right, but I wasn’t actually asking for you to generate a formal test in either Test/ or Test2/, but rather to give me a test file (or point me at what I would do to generate one) just so I can test the PR! :-) (I guess you can either think of me as being thorough or lazy or both. :-)

dmj commented 4 years ago

@sydb You can take https://github.com/dmj/Stylesheets/blob/t/ant-test-to-html/Test2/inputFiles/test-382.xml and the expected result in https://raw.githubusercontent.com/dmj/Stylesheets/t/ant-test-to-html/Test2/expected-results/test-382.html

sydb commented 2 years ago

@dmj — I was prodded to look at this again (by the ever-efficient @HelenaSabel), and see that I never posted a reply to your 02 Nov 20 post. Those links give me 404 errors. (And did when I tried them some time ago, but I have no idea how long ago that was. May have been 03 Nov 20 or 03 May 22 for all I know. :-) But more importantly, they still give me 404 errors now.

sydb commented 2 years ago

So my instinct is not to let this fix go for an entire year without pulling it in. Especially since it seems pretty straight forward, and the code changes look fine at first glance. But not only can I not find the test files you refer to, @dmj, I cannot find the entire repo, including the branch to pull in from.

dmj commented 2 years ago

Both, test and repo are long gone. I'll try to recreate them.

peterstadler commented 2 years ago

Release Team looked at it and approved for current release 7.54.0