TEIC / Stylesheets

TEI XSL Stylesheets
231 stars 124 forks source link

common_tagdocs.xsl ignores `<tag>/@type` #503

Closed martindholmes closed 10 months ago

martindholmes commented 3 years ago

The spec for the <tag> element includes values for @type including "start, "end", "empty" etc.

https://www.tei-c.org/release/doc/tei-p5-doc/en/html/ref-tag.html

However, the template that renders the element, in common_tagdocs.xsl (l.1852) ignores those values:

 <xsl:template match="tei:tag">
    <xsl:element namespace="{$outputNS}" name="{$hiName}">
      <xsl:attribute name="{$rendName}">
        <xsl:text>tag</xsl:text>
      </xsl:attribute>
      <xsl:text>&lt;</xsl:text>
      <xsl:apply-templates/>
      <xsl:text>&gt;</xsl:text>
    </xsl:element>
  </xsl:template>

I think appropriate content should be inserted, so that:

Otherwise I don't see much point in these @type values at all.

sydb commented 2 years ago

Assigning @npcole and @JanelleJenstad just to remind them that they are assigned to review the associated pull request.