search

TEIC / Stylesheets

TEI XSL Stylesheets
231 stars 124 forks source link

Addressing `@preserveOrder` for #241 #507

Closed joeytakeda closed 2 years ago

joeytakeda commented 3 years ago

This batch of commits modifies odd2odd.xsl, which was dropping @preserveOrder (and all other attributes) on <sequence>. There are also some new tests added to Test2 to confirm that preserveOrder is reflected in the RNG output.

joeytakeda commented 2 years ago

Thanks, @sydb — agreed on all fronts here. I'll make those changes now.

sydb commented 2 years ago

@joeytakeda For reasons I do not understand, some of the tests in Test/ are now failing. I have both fixed them in a commit to this repo on my local machine, and @HelenaSabel and I have changed the Test/Makefile program so that these should not cause errors in the future. (Simultaneously making the test slightly weaker.) So could you either

  1. Give me r/w permission to this repo, or
  2. Merge in the latest from the upstream TEIC/Stylesheets:dev branch into here, and try re-running the tests yourself. Thanks.
joeytakeda commented 2 years ago

Hi @sydb I've merged the changes from TEIC/Stylesheets:dev into the branch and both make test and make test2P are successful locally (the tests have failed here, but I think that's just because of the Slack webhook?)

sydb commented 2 years ago

@joeytakeda — Sorry, did not notice your reply of 9 days ago. (And I even left this tab open in my browser for 2 weeks just so I would see it! Sigh.)

This passes all tests on my local system (except this bug interfered), except for whitespace in the test30.rnc output. So I think it should be merged right away, before more divergence occurs. (And we can fix the test30 output after it is merged.)

Oh. It is assigned to me. So I will merge it now, and hope to fix the test30 problem within an hour.